mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> safaalfulaij wrote in ProgressBar.qml:33
> Actually, it’s used in default QQC2 styling and I just stole it from there..
> http://code.qt.io/cgit/qt/qtquickcontrols2.git/tree
safaalfulaij added inline comments.
INLINE COMMENTS
> broulik wrote in ProgressBar.qml:33
> That's pretty clever, actually,
>
> > A negative scale causes the item to be mirrored when rendered.
>
> However, not sure we can just blatantly mirror that graphic
Actually, it’s used in default QQC2 s
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ProgressBar.qml:33
> I don't understand what this is doing?
That's pretty clever, actually,
> A negative scale causes the item to be mirrored when rendered.
However, not sure we can just blatantly mirror that graphic
REP
davidedmundson added inline comments.
INLINE COMMENTS
> ProgressBar.qml:33
> contentItem: Item {
> +scale: control.mirrored ? -1 : 1
> PlasmaCore.FrameSvgItem {
I don't understand what this is doing?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://p
safaalfulaij added a comment.
One widget I didn't know how to fix is the TabBar (The blue line that flows
from left to right for the first item.)
Other widgets are behaving the same as QQC2 ones, like BusyIndicator and
Dial, so I didn't change them. Not sure if they should be flipped or not
safaalfulaij created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Some widgets are missed up in RTL mode, this should fix it.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REV
