This revision was automatically updated to reflect the committed changes.
Closed by commit R169:57d9bf1d73c8: Add a property to hide the PageRow
separator matching AbstractListItem. (authored by hein).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7509?vs=18
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7509
To: hein, mart
Cc: davidedmundson, plasma-devel, apol, mart
hein updated this revision to Diff 18682.
hein added a comment.
Fix prop description
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7509?vs=18670&id=18682
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7509
AFFECTED FILES
src/controls/
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in PageRow.qml:96
> A bit misleading, as when container.level is 0 this isn't false.
the wording should be
"True if the separator between pages should be visible"
when the level is 0 this is false anyways as this property is set
davidedmundson added inline comments.
INLINE COMMENTS
> PageRow.qml:96
> + * separatorVisible: bool
> + * True if the separator between pages is visible
> + * default: true
A bit misleading, as when container.level is 0 this isn't false.
REPOSITORY
R169 Kirigami
REVISION DETAIL
hein created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7509
AFFECTED FILES
src/controls/PageRow.qml
To: hein, mart
Cc: pla
