D7486: Handle buffer scales changing dynamically

2017-08-24 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R108:95c983e6d858: Handle buffer scales changing dynamically (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7486?vs=18672&id=18692 REVISION D

D7486: Handle buffer scales changing dynamically

2017-08-24 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xdgv6 REVISION DETAIL https://phabricator.kde.org/D7486 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-moha

D7486: Handle buffer scales changing dynamically

2017-08-24 Thread David Edmundson
davidedmundson updated this revision to Diff 18672. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Move into scene REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7486?vs=18601&id=18672 BRANCH xdgv6 REVIS

D7486: Handle buffer scales changing dynamically

2017-08-23 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in shell_client.cpp:226 > Explicitly for scale changed? > > Can do, but at that point we may as well have Scene connect to > c->surface(), &SurfaceInterface::scaleChanged > > which would also work. > > I'm fine with any.

D7486: Handle buffer scales changing dynamically

2017-08-23 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in shell_client.cpp:226 > Should we maybe introduce a dedicated signal? Explicitly for scale changed? Can do, but at that point we may as well have Scene connect to c->surface(), &SurfaceInterface::scaleChanged which woul

D7486: Handle buffer scales changing dynamically

2017-08-23 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > shell_client.cpp:226 > +//we need to rebuild our window quads > +emit geometryShapeChanged(this, geom); > +} Should we maybe introduce a dedicated signal? REPOSITORY R108 KWin REVISION DETAIL https://phabric

D7486: Handle buffer scales changing dynamically

2017-08-23 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Currently when a client changes it's buffer size the result is corrupt until we move the window. When a client buffer sc