D7361: Get rid of QSignalMapper

2017-08-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1419135a5d99: Get rid of QSignalMapper (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7361?vs=18280&id=18327 REVISION DET

D7361: Get rid of QSignalMapper

2017-08-17 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7361 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliez

D7361: Get rid of QSignalMapper

2017-08-17 Thread David Edmundson
davidedmundson added a comment. > Is it intentional that in AppletInterface removeAction does not remove them from the KActionCollection but only m_actions QStringList? This is only done in the WallpaperInterface. It does implicitly. KactionCollection watches for actions being destroyed.

D7361: Get rid of QSignalMapper

2017-08-17 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Use lambdas instead. TEST PLAN This is slightly faster. Verified that applet actions are still added and can be t