This revision was automatically updated to reflect the committed changes.
Closed by commit R108:00281711d9c4: Handle processId being 0 in
ShellClient::killWindow (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7168?vs=17787&id=17798
REVIS
graesslin added a comment.
In https://phabricator.kde.org/D7168#133094, @bshah wrote:
> Looks good to me, probably though it's good idea to figure out why it
returns 0 as processId?
We have a failing auto test for it in KWayland. It looks like
libwayland-server is using a linuxis
bshah accepted this revision as: bshah.
bshah added a comment.
This revision is now accepted and ready to land.
Looks good to me, probably though it's good idea to figure out why it returns
0 as processId?
REPOSITORY
R108 KWin
BRANCH
kill-window-process-0
REVISION DETAIL
https://phabr
graesslin added a project: FreeBSD.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7168
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol, mart, lukas
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
If ClientConnection fails to get the process id (which happens at least
on FreeBSD) the process id is 0. We should not try to terminate
