D7065: warning--

2017-08-02 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1bd3145694b6: warning-- (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7065?vs=17551&id=17572 REVISION DETAIL https://phabricator.k

D7065: warning--

2017-08-02 Thread Harald Sitter
sitter added a comment. In https://phabricator.kde.org/D7065#131436, @anthonyfieroni wrote: > So, why don't make lamba without parameters? Same reason it didn't use a `(bool activate)` signature, whatever that reason might have been I could not say. Not my code. REPOSITORY R120

D7065: warning--

2017-08-02 Thread Anthony Fieroni
anthonyfieroni added a comment. So, why don't make lamba without parameters? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7065 To: sitter, apol Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7065: warning--

2017-08-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7065 To: sitter, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D7065: warning--

2017-08-02 Thread Harald Sitter
sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY active is unused, don't declare it TEST PLAN no compiler warning raised about the unused var anymore REPOSITORY R120 Plasma Workspace BRA