This revision was automatically updated to reflect the committed changes.
Closed by commit R120:94aa4152937f: [Scripting] Throw a error from the
Containment when the widget is not found (authored by garg).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6424
To: garg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-
garg updated this revision to Diff 15970.
garg added a comment.
Remove useless debug
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6424?vs=15969&id=15970
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6424
AFFECTED FILES
shell
garg updated this revision to Diff 15969.
garg added a comment.
Remove accidentally commited file
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6424?vs=15968&id=15969
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6424
AFFECTED
garg updated this revision to Diff 15968.
garg added a comment.
Update as per David's comments
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6424?vs=15962&id=15968
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6424
AFFECTED FIL
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
In principle fine.
INLINE COMMENTS
> containment.cpp:217
> return env->wrap(applet);
> }
> }
what about this one?
> contai
garg updated this revision to Diff 15962.
garg added a comment.
Mention the name of the widget too
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6424?vs=15961&id=15962
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6424
AFFECTED
garg added a reviewer: Plasma.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6424
To: garg, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
garg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Let's also move the applet pointer to right before it's used and
remove duplicated declarations.
REPOSITORY
R120 Plasma Workspace
BRANCH
m
