This revision was automatically updated to reflect the committed changes.
Closed by commit R120:13aa418c2772: get rid of manual window flags setting on
controller (authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6403?vs=15905&id=1611
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> mart wrote in panelconfigview.cpp:69
> note: removing the whole line seems to be necessary as seems that setting any
> flag does break focus
I can see
mart added inline comments.
INLINE COMMENTS
> panelconfigview.cpp:69
> KWindowSystem::setState(winId(), NET::KeepAbove);
> -setFlags(Qt::WindowFlags((flags() | Qt::FramelessWindowHint |
> Qt::WindowStaysOnTopHint) & (~Qt::WindowDoesNotAcceptFocus)));
> KWindowSystem::forceActiveWin
mvourlakos added a comment.
> That was about the missing clicks?
Sorry if I understood wrongly the case... we did this for config window in
wayland in order to receive the focuslost event and close itself
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde
davidedmundson added a comment.
> David in Latte we solved this by keeping the flag but removing the dock
type for the configuration window and of course keep also the keepabove
That was about the missing clicks?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.k
mvourlakos added a comment.
David in Latte we solved this by keeping the flag but removing the dock type
for the configuration window and of course keep also the keepabove
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6403
To: mart, #plasma
Cc: mvourlakos
mart added a comment.
In https://phabricator.kde.org/D6403#119866, @davidedmundson wrote:
> Any idea why it was set to not take focus in the first place?
>
> What makes the other 2 flags redundant?
it's ~Qt::WindowDoesNotAcceptFocus so the idea was to make it take focus
again
davidedmundson added a comment.
Any idea why it was set to not take focus in the first place?
What makes the other 2 flags redundant?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6403
To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progw
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
with Qt 5.9, the panel controller can't get focus, so
it can't be dismissed by clicking anywhere, (couldn't
figure out what was the commit tha
