D6358: Use KRun::runApplication when possible; split out and share more code.

2017-06-23 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee79239a5de7: Use KRun::runApplication when possible; split out and share more code. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D635

D6358: Use KRun::runApplication when possible; split out and share more code.

2017-06-23 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6358 To: hein, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6358: Use KRun::runApplication when possible; split out and share more code.

2017-06-23 Thread Eike Hein
hein updated this revision to Diff 15789. hein added a comment. Ref-ify. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6358?vs=15788&id=15789 BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6358 AFFECTED FILES libtaskmanag

D6358: Use KRun::runApplication when possible; split out and share more code.

2017-06-23 Thread Eike Hein
hein updated this revision to Diff 15788. hein added a comment. Collapse the requestOpenUrls implementations as well; more sanity checking for app-service-ness. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6358?vs=15787&id=15788 BRANCH Plasma

D6358: Use KRun::runApplication when possible; split out and share more code.

2017-06-23 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY I'm not particularly happy about adding more X11 code outside of XWindowTasksModel, but it means greater code reuse (in something that has experienced unwelcome drift before) and there's a precedent