D6027: Use existing parseInt function

2017-09-20 Thread David Edmundson
davidedmundson abandoned this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6027 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D6027: Use existing parseInt function

2017-09-20 Thread Sebastian Kügler
sebas resigned from this revision. sebas added a comment. Please abandon, I've already fixed this in master. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6027 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m

D6027: Use existing parseInt function

2017-08-28 Thread Sebastian Kügler
sebas requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6027 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6027: Use existing parseInt function

2017-08-24 Thread Sebastian Kügler
sebas added a comment. This one slipped my attention. I think it's still relevant? INLINE COMMENTS > doctor.h:54 > bool setPosition(int id, const QPoint &pos); > +bool setScale(int id, int scale); > bool setMode(int id, const QString &mode_id); Unrelated? REPOSITORY R110 KSc

D6027: Use existing parseInt function

2017-05-30 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There's already a QString::toInt() that validates input. We don't need to make our own. Also there was a bug in the current point