D6014: Small improvements in IconItem

2017-05-29 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3b303d736317: Small improvements in IconItem (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6014?vs=14943&id=14949 REVISION

D6014: Small improvements in IconItem

2017-05-29 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6014 To: apol, #frameworks, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-moha

D6014: Small improvements in IconItem

2017-05-29 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 14943. apol added a comment. Few additions REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6014?vs=14939&id=14943 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6014 AFFECTED FILES sr

D6014: Small improvements in IconItem

2017-05-29 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Don't construct a QUrl for every source strings. Check it's a file url first (which is the only kind of url we support at the moment)