broulik added a comment.
In principle it works but when I unplug and plug back in AC, sometimes it
changes brightness or at least moves the brightness slider around for some
weird reason and then the brightness doesn't match the slider anymore.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
lukas added a comment.
Works fine for me in general, with 2 caveats:
- the brightness change doesn't animate (but afaik that's expected)
- when switching back to AC, the brightness isn't restored (stays at the
previous "battery" level)
REPOSITORY
R122 Powerdevil
REVISION DETAIL
ht
broulik added a comment.
Writing to sysfs brightness with some wonky bash script is a pretty common
thing IMHO but any simplification of brightness code is a good thing. +1
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D5976
To: bshah, #plasma, broulik
Cc: david
bshah updated this revision to Diff 14860.
bshah added a comment.
remove workaround added in the https://phabricator.kde.org/D2470
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5976?vs=14859&id=14860
BRANCH
remove-udevqt
REVISION DETAIL
https://ph
bshah added a comment.
In https://phabricator.kde.org/D5976#111940, @davidedmundson wrote:
> I don't understand, you're saying your removing covering a corner case?
Right, yes.. but that corner case is very less likely to happen other then
someone writing manually to sysfs file
R
davidedmundson added a comment.
I don't understand, you're saying your removing covering a corner case?
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D5976
To: bshah, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
ali
bshah created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This code watches the device in the sysfs for changes, if device is
changed it reads the brightness again and updates it.
However that is,
