D5886: Use QFormLayout for sliders

2017-05-17 Thread Alexander Volkov
This revision was automatically updated to reflect the committed changes. Closed by commit R100:f5905ee018cd: Use QFormLayout for sliders (authored by volkov). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5886?vs=14627&id=14636 REVISION DETAIL https://phab

D5886: Use QFormLayout for sliders

2017-05-17 Thread Alexander Volkov
volkov updated this revision to Diff 14627. volkov added a comment. use QSpacerItem instead of QWidget for spacing REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5886?vs=14596&id=14627 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5886 AF

D5886: Use QFormLayout for sliders

2017-05-16 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. well that's a billion times cleaner. INLINE COMMENTS > kgamma.cpp:243 > +form->addRow(gammalabel, gctrl); > +form->addWidget(new QWidget); // extra spacing > +fo

D5886: Use QFormLayout for sliders

2017-05-16 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFormLayout is more natural for label/widget pairs and allows to have uniform label alignment in different styles. REPOSITORY R100 KGamma