davidedmundson abandoned this revision.
davidedmundson added a comment.
That would also be completely fine from my POV.
I should have read the original review request, I was just fixing the tests
based on what was currently here.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phab
graesslin added a comment.
In https://phabricator.kde.org/D5851#109478, @davidedmundson wrote:
> It makes absolutely no sense to have a pidChanged signal and then say
clients shouldn't be using it.
>
> Either window has no reason to have a pidChanged signal or we should
connect to it
davidedmundson added a comment.
It makes absolutely no sense to have a pidChanged signal and then say clients
shouldn't be using it.
Either window has no reason to have a pidChanged signal or we should connect
to it. It has to be one or the other.
REPOSITORY
R127 KWayland
REVISION DE
graesslin added inline comments.
INLINE COMMENTS
> plasmawindowmodel.cpp:84
>
> +QObject::connect(window, &PlasmaWindow::pidChanged, q,
> +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); }
In the original report I critized that we connect to a pid changed signal
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Fixes https://phabricator.kde.org/D5747
TEST PLAN
Tests now pass
REPOSITORY
R127 KWayland
BRANCH
