This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e3293e9c05b5: Add support for remote image sources to
DesktopIcon (authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5764?vs=14282&id=14309#toc
REPOSITORY
R169 Kirigami
CH
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> desktopicon.cpp:366
> }
> +} else if(iconSource.startsWith("http://";) ||
> iconSource.startsWith("https://";)) {
> +if(!m_loadedImage.isNull()) {
cod
leinir added a comment.
In https://phabricator.kde.org/D5764#108019, @apol wrote:
> Don't we also have to add support for when DesktopIcon::m_source is a QIcon?
That's already covered in DesktopIcon::updatePaintNode's big switch
statement, where it checks for what type is actually
apol added a comment.
Don't we also have to add support for when DesktopIcon::m_source is a QIcon?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D5764
To: leinir, mart, apol
Cc: plasma-devel, apol
leinir created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds support for images hosted on http(s) remotes to the DesktopIcon
item. It uses the qnam from the qqmlengine the item is associated w
