This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d3bdb8d657ba: workaround for correct wayland positioning
(authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5748?vs=14556&id=14835
REVISIO
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D5748
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: hein, davidedmundson, graesslin, plasm
mart added a comment.
In https://phabricator.kde.org/D5748#111625, @hein wrote:
> Did we do the 5.7 test?
ah, i understood David did, sorry
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland
Cc: hein, davi
hein added a comment.
Did we do the 5.7 test?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland
Cc: hein, davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg,
mart added a comment.
ping?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas,
mart added a comment.
In https://phabricator.kde.org/D5748#110388, @davidedmundson wrote:
> edit, ignore that last comment. I hadn't seen it was a QPointer.
>
> Just my comment about checking on all other plaforms remains.
i could check on wayland Qt 5.9, X Qt 5.8, both seemed
davidedmundson added a comment.
edit, ignore that last comment. I hadn't seen it was a QPointer.
Just my comment about checking on all other plaforms remains.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland
Cc:
davidedmundson added a comment.
Is it tested on X, Qt 5.7 as well as Qt 5.9
If you want me to do any of those, just ask.
INLINE COMMENTS
> view.cpp:250
> +} else if (event->type() == QEvent::Hide) {
> +delete m_plasmaShellSurface;
> } else if (m_plasmaShellSurface && eve
mart marked 2 inline comments as done.
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in view.cpp:248
> When we get here we've already run Dialog::event()
>
> won't that have already done the positioning?
>
> There's a virtual geometry method in dialog to allow krunner and s
mart updated this revision to Diff 14556.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- don't execute event two times
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5748?vs=14250&id=14556
davidedmundson added inline comments.
INLINE COMMENTS
> view.cpp:237
> +if (!s) {
> +return PlasmaQuick::Dialog::event(event);
> }
return retval.
otherwise you're processsing it twice.
> view.cpp:248
> +//positionOnScreen tried to position i
mart added reviewers: Plasma, Plasma on Wayland.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts
davidedmundson added a comment.
> I assume this are adjustments for Qt 5.8 or later. How does this work with
Qt 5.7? I fear if we change like this we are going to break Qt 5.7.
Yes, in combination with the other two. There's some notes on
https://phabricator.kde.org/T6064.
It's a valid
graesslin added a comment.
I assume this are adjustments for Qt 5.8 or later. How does this work with Qt
5.7? I fear if we change like this we are going to break Qt 5.7.
INLINE COMMENTS
> view.cpp:217
> {
> +qWarning()< // QXcbWindow overwrites the state in its show event. There ar
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
as showEvent is too soon, create the plasma surface on
:Expose event, and reposition the surface
TEST PLAN
krunner is correctly positioned wi
15 matches
Mail list logo
