This revision was automatically updated to reflect the committed changes.
Closed by commit R135:ac9d4b9cd382: Move code on wayland surface being created.
(authored by davidedmundson).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
graesslin accepted this revision.
graesslin added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kwaylandintegration.cpp:157
> +
> +#include "kwaylandintegration.moc"
Just wondering: why is the moc file needed now?
REPOSITORY
R135 Integration for Qt applic
davidedmundson updated this revision to Diff 14271.
davidedmundson added a comment.
Remove leftover code
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5746?vs=14245&id=14271
BRANCH
testing
REVISION DETAIL
https://pha
graesslin added inline comments.
INLINE COMMENTS
> kwaylandintegration.cpp:42
>
> +static bool s_useQt58Workaround;
> +
I don't really like the name of the variable as it's going to be the future way
and not "a workaround" once we depend on Qt 5.8 or later.
REPOSITORY
R135 Integration for
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5746
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, le
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We need to setup our attachments when the wl_surface is created.
This gets recreated when a window is hidden and shown.
QPlatform
