This revision was automatically updated to reflect the committed changes.
Closed by commit R127:93fb3260679b: Validate surface is valid when sending
TextInput leave event (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5712?vs=141
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Thanks for adding the test!
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5712
To: davidedmundson, #plasma, graesslin
Cc: apol, graesslin
davidedmundson updated this revision to Diff 14157.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Also validate the enterEvent, this makes it symetric to pointer enter/leave
events that have the same check.
I've also add
apol added a comment.
+1
FWIW, this fixes my initial issue.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5712
To: davidedmundson, #plasma, graesslin
Cc: apol, graesslin, plasma-devel, #frameworks, spstarr, progwolff, Zren,
lesliezhai, ali-mohamed, jensreuterbe
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please add a unit test case.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5712
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-dev
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It's possible for the surface to be unbound when we send the leave
event; we've called Resource::unbi
