D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

2017-07-25 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R120:dba0f80288b4: AppMenu: Don't call AboutToShow on LayoutUpdated (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5705?vs=14124&id=17183#toc REPOSITORY R120 Plasma Workspac

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

2017-07-14 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If something is worth deleting, it's worth deleting properly. Kill the whole method. We can always revert it. REPOSITORY R120 Plasma Workspace BRANCH dbusmenu-fakeun

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

2017-07-14 Thread David Rosca
drosca added a comment. Any comments on this? It is still broken. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5705 To: drosca, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

2017-05-03 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This workaround is there (according to the comment) for Firefox, but I still don't get any appmenu in Firefox at all. It breaks applications