This revision was automatically updated to reflect the committed changes.
Closed by commit R115:d78689251344: Applet: Automatically raise maximum volume
when over defined maximum volume (authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabric
drosca added inline comments.
INLINE COMMENTS
> sebas wrote in ListItemBase.qml:282
> Should be "volume", since that's the property. Or perhaps we don't need
> "volume" or "Volume".
"Volume" is a role from the model, so assigning to the "volume" property
instead only makes it go through one in
sebas added a comment.
You're right, forgot to submit the cosmetical comment.
INLINE COMMENTS
> ListItemBase.qml:282
> +if (!slider.forceRaiseMaxVolume && Volume >
> PulseAudio.NormalVolume) {
> +Volume = PulseAudio.NormalVolume;
> +}
Shou
drosca added a comment.
In https://phabricator.kde.org/D5695#106996, @sebas wrote:
> Cosmetical comment aside, looks good.
What's that cosmetical comment? Did you forget to send it?
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
auto-raise-volume (branched from master)
RE
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Cosmetical comment aside, looks good.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
auto-raise-volume (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5695
To:
drosca updated this revision to Diff 14109.
drosca added a comment.
Fix issue pointed by Zren
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5695?vs=14105&id=14109
BRANCH
auto-raise-volume (branched from master)
REVISION DETAIL
http
drosca added a comment.
In https://phabricator.kde.org/D5695#106714, @Zren wrote:
> I'm guessing the side effect of this method is that if you uncheck "force
boost" when the volume is 150%, it will stay at 150% volume until you manually
slide it down to below 100%? If it does, wouldn't i
Zren added a comment.
Hmmm, this seems better than my solution since mine stays in the boosted
state (slide.maxValue=150%) after the volume when back below 100%.
I'm guessing the side effect of this method is that if you uncheck "force
boost" when the volume is 150%, it will stay at 150%
drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When volume is above the maximum volume set in applet, moving the volume
slider will only lower it to the maximum applet volume.
This change
