D5685: Create context with pa_context_new_with_proplist

2017-05-02 Thread David Rosca
drosca added a comment. > Why won't it work? There is no i18n used in the library, so I guess it needs to be configured first. Or is it done automagically? :D REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5685 To: drosca, #plasma Cc: davide

D5685: Create context with pa_context_new_with_proplist

2017-05-02 Thread David Edmundson
davidedmundson added a comment. Why won't it work? you just need to pa_proplist_sets(proplist, PA_PROP_APPLICATION_NAME, i18n("Plasma Volume Applet").toUtf8())); REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5685 To: drosca, #plasma Cc

D5685: Create context with pa_context_new_with_proplist

2017-05-02 Thread David Rosca
drosca abandoned this revision. drosca added a comment. In https://phabricator.kde.org/D5685#106435, @davidedmundson wrote: > what do we gain from doing this? Not much, docs just say this should be used instead of pa_context_new. When/If we create streams (eg. for monitors), they

D5685: Create context with pa_context_new_with_proplist

2017-05-02 Thread David Edmundson
davidedmundson added a comment. what do we gain from doing this? INLINE COMMENTS > context.cpp:544 > +pa_proplist *proplist = pa_proplist_new(); > +pa_proplist_sets(proplist, PA_PROP_APPLICATION_NAME, "plasma-pa"); > +pa_proplist_sets(proplist, PA_PROP_APPLICATION_ID, > "org.kde.

D5685: Create context with pa_context_new_with_proplist

2017-05-02 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Works same as before REPOSITORY R115 Plasma Audio Volume Applet BRANCH connect-proplist (branched from master) REVISION DETAIL https://phabric