hein added a comment.
> Can't your just connect to "this" for the dataChanged
No, because then I'd also get dataChanged for rows from launcherTasksModel
and would have to loop over all indices in the range to ignore them.
It's kind of ugly either way. The applet code will currently r
davidedmundson added inline comments.
INLINE COMMENTS
> tasksmodel.cpp:213
> +if (roles.contains(AbstractTasksModel::AppId) ||
> roles.contains(AbstractTasksModel::LauncherUrlWithoutIcon)) {
> +q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1,
> 0),
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3546de221549: Introduce a HasLauncher data role.
(authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5504?vs=13631&id=13632
REVISION DETAIL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5504
To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreu
hein updated this revision to Diff 13631.
hein added a comment.
Update HasLauncher when windows or startups update roles evaluated by
appsMatch.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5504?vs=13590&id=13631
BRANCH
master
REVISION DETAI
davidedmundson added a comment.
appsMatch depends on AppId and LauncherURLWithoutIcon
You're handling launcherTasksModel changing, but can we rely on this data
being static for a proxyIndex?
If not, we need to connect to TasksModel::dataChanged for those roles and
potentially then e
hein added a dependent revision: D5505: Keep startup notifications
launcher-sized when inserting at launcher position..
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5504
To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This is implemented by TasksModel and allows clients to reliably
query whether a row has an associated launcher. Useful for things
like Pin/Unpin action state or layout decisions.
Previously cli
