This revision was automatically updated to reflect the committed changes.
Closed by commit R104:c67271c0f207: Set xrdb XFT.DPI value as integer (authored
by davidedmundson).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5487?vs=13550&id=13725
REVISION DETAIL
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R104 KScreen
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5487
To: davidedmundson, #plasma, mart
Cc: hetzenecker, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterbe
hetzenecker added a comment.
Awesome! Looks good, this fixes the wrong icon sizes in plasma.
"xrdb -query" reports the correct size and .config/kcmfonts now also stores
the integer value. This means the "Force fonts DPI" size is now also shown in
the Fonts systemsettings module.
Tes
davidedmundson updated this revision to Diff 13550.
davidedmundson added a comment.
fixup
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5487?vs=13549&id=13550
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5487
AFFECTED FILES
kcm/src/s
hetzenecker added inline comments.
INLINE COMMENTS
> scalingconfig.cpp:124
> {
> -return scaleFactor() * 96.0;
> +return qRound(scaleFactor()) * 96.0;
> }
I'd propse
qRound(scaleFactor() * 96.0)
to get int values. If the scaleFactor is rounded, we only get multiplies of 96
as DPI.
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QXcbScreen when loading uses QByteArray.toInt().
QByteArray("152.23").toInt() returns 0, rather than a rounded version,
this mean
