D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R495:ef8548fadc39: Nextcloud upload purpose plugin (authored by Lim Yuen Hoe ). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5464?vs=13598&id=13619 REVISION D

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim added a comment. Sure! I was planning to. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, #plasma, apol Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Okay, let's integrate it and then we see how it works. Can you maybe blog about it so the world knows? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 13598. yuenlim added a comment. Oops minor mistake. Forgot to remove the declaration of createTargetUrl REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5464?vs=13596&id=13598 REVISION DETAIL https://phabricato

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim marked 2 inline comments as done. yuenlim added a comment. Hope the translation domain part is correct. I only found it in the phabricator plugin's CMakeLists, most of the other plugins don't seem to have it. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kd

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 13596. yuenlim added a comment. Addressed comments! REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5464?vs=13470&id=13596 REVISION DETAIL https://phabricator.kde.org/D5464 AFFECTED FILES src/plugins/CMakeL

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. +1 Please look at David's comments and we'll integrate it. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, #plasma, apol Cc: davi

D5464: Nextcloud Upload Purpose Plugin

2017-04-18 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:8 > + > + you need to set the translation domain (copy and paste the line from another CMakeLists) > nextcloudjob.cpp:82 > + > +void NextcloudJob::checkTargetFile(const int suffix, const QUrl& local, > KJob* j) > +{ Repla

D5464: Nextcloud Upload Purpose Plugin

2017-04-18 Thread Yuen Hoe Lim
yuenlim added a comment. Ping :) Think someone can help me review this? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, #plasma, apol Cc: graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D5464: Nextcloud Upload Purpose Plugin

2017-04-15 Thread Martin Gräßlin
graesslin added a comment. neat :-) Looking forward to use it REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, apol, #plasma Cc: graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5464: Nextcloud Upload Purpose Plugin

2017-04-15 Thread Yuen Hoe Lim
yuenlim created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A basic-ish nextcloud purpose plugin for use with quickshare. Uses the owncloud kaccount provider (had a hoot of a time figuring that out!).