This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9a13743c4988: Don't update the focused pointer Surface if
a button is pressed (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5461?vs=13474&id=
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Fine by me :)
You did forgot an "&" (making it by reference). On the other hand, this is a
POD type where performance wise this wouldn't matter at all.
REPOSITORY
R108 KWin
BRANCH
n
graesslin updated this revision to Diff 13474.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Use range-based for loop with qAsConst
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5461?vs=13456&id=13474
BRANCH
markg added inline comments.
INLINE COMMENTS
> graesslin wrote in pointer_input.cpp:440
> > Just curious, why do you define end as opposed tho this:
>
> Because @broulik tends to point out that it is not cached.
>
> > Another route you can go which looks much cleaner imho (requires Qt 5.7
> >
graesslin added a subscriber: broulik.
graesslin added inline comments.
INLINE COMMENTS
> markg wrote in pointer_input.cpp:440
> Just curious, why do you define end as opposed tho this:
> for (auto it = m_buttons.constBegin(); it != m_buttons.constEnd(); it++) {
>
> }
>
> Another route you can
markg added inline comments.
INLINE COMMENTS
> pointer_input.cpp:440
> +auto areButtonsPressed = [this] {
> +for (auto it = m_buttons.constBegin(), end = m_buttons.constEnd();
> it != end; it++) {
> +if (it.value() == InputRedirection::PointerButtonPressed) {
Just curiou
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
During pointer motion we already had the condition that an update of
focused pointer surface can only happen when no button is pressed.
