davidedmundson added a comment.
You cannot repurpose useHoverEffects.
The documentation says that is for disabling hoverEnabled on a bunch of items
- so they don't even get hover events.
(albeit only in QtQuickControls2 ...for now) because it has a high
performance cost.
Despite i
mart added a comment.
In https://phabricator.kde.org/D5428#101932, @hein wrote:
> To go one further, we could add a mechanism to allow downstreams to set the
style hint via the LnF package, then we (maybe) don't even need the checkbox.
+1
breeze should follow the hint then
REPO
hein added a comment.
To go one further, we could add a mechanism to allow downstreams to set the
style hint via the LnF package, then we (maybe) don't even need the checkbox.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: bro
broulik added a comment.
In the Plasma QPT, yes, we already have something similar for whether to use
animations iirc in widget style advanced settings
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-de
hein added a comment.
Then we'd need to adapt Breeze to follow the style hint, and put a global
option into the Style KCM to set through the QPA?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-devel, p
broulik added a comment.
http://doc.qt.io/qt-5/qstylehints.html#useHoverEffects-prop
I think that's exactly what we want (added in Qt 5.8)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-devel, prog
hein added a comment.
Can you tell us more about QStyleHints useHoverEffects? Is this a real thing
that's coming, or a proposal?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-devel, progwolff, lesliez
broulik added a comment.
I'd prefer postponing this until we can use `QStyleHints useHoverEffects` at
which point we can make it global for Plasma and all other places.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, c
hein added a comment.
No, inappropriate is stuff like "which is out of topic and not very pleasant"
in a rational discussion over contribution and maintance workflows in the KDE
community (which you started). It's even more inappropriate to resort to ad
hominems suggesting I act out of frust
hpereiradacosta added a comment.
Colomar: could you also comment on "https://phabricator.kde.org/D5429"; ?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg
hpereiradacosta added a comment.
At least we could explain there to our user why we would prefer not to
implement the said feature
(as I have done politely multiple times already, without ending up being
accused of not trying to satisfy the needs for our dowstreams)
REPOSITORY
R31 Breeze
hpereiradacosta added a comment.
ps: is there a bug (= wish) report somewhere about this so importantly needed
feature ?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed,
hpereiradacosta added a comment.
"I think it's regrettable that the current Plasma default theme isn't
interested in satisfying the needs of our downstreams and do wonder if that
situation will have to be addressed somehow,"
I think this is a completely overstated and innapropriate statemen
hein added a comment.
I think it's regrettable that the current Plasma default theme isn't
interested in satisfying the needs of our downstreams and do wonder if that
situation will have to be addressed somehow, but thanks for your input.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://ph
hein abandoned this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
hpereiradacosta added a comment.
"This is also why there's engines like the highly configurable QtCurve (and a
big aftermarket of 500+ QtCurve themes/config on the KDE Store), instead of 500
different style engines."
That is out of topic
Breeze is not QtCurve, and possibly, it is because
hein added a comment.
> If it's most likely to be decided only on the distribution level, we don't
necessarily need a GUI for switching it, do we? We could also just have it as
an unexposed parameter in the config file.
Yes, although options being hidden tends to excercabate maintenance
colomar added a comment.
If it's most likely to be decided only on the distribution level, we don't
necessarily need a GUI for switching it, do we? We could also just have it as
an unexposed parameter in the config file.
I think Breeze (like Oxygen) already has too many user-visible conf
hein added a comment.
Aye. I've pinged Jens, Ken and Thomas with the link.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
hpereiradacosta added a comment.
... VDG also gives oppinions about what should be an option and what should
not
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
hein added a comment.
I don't see VDG/UX input helping on this issue. We know there are working
systems that behave in this way and are usability-tested. The VDG could only
give an opinion on what it wants to see in Plasma by default, and this patch
doesn't aim to change a default. It's an o
hpereiradacosta added a comment.
I'm not so much talking about the value of having the code upstream (of
course everybody wants their code upstream, to get relieved from the
maintenance burden), but on the feature itself, which in my opinion is too
little to be upstreamed.
as for the offer
hein added a comment.
Regarding the general topic of "to hover effect or not to hover effect", I
personally see the utility of hover effects and am fine with them being on by
default. However, it's also true that other systems seem to do fine without
them and I can see how some might prefer
hein added a comment.
BTW I'll add this is a very common predicament in FOSS and it's the reason
why kernel.org has a "code should be upstream" and "if real systems ship it, we
should merge it" policy. History/experience has shown again and again that
downstream deltas end up being a problem
hein added a comment.
The added value for users is getting regular bugfixes from upstream Breeze.
After extensive experience with Oxygen and Breeze forks by distros over five
years, they basically always got outdated. I'd much rather maintain this option
upstream (which I can offer to do for
hpereiradacosta added a comment.
(for me at least, hover effect is something very useful to identify that an
item is clickable. Admittedly, this is not very necessary for buttons, but for
things like expander and scrollbar arrows, which otherwise appear just like
text, it certainly helps).
hpereiradacosta added a comment.
Should add Usability and design experts to reviewers.
As far as I am concern, I don't see much use of adding an option (and the
code complexity that goes along), in order to disable a rather core (and very
usefull, usability wise, in my humble oppinion) fe
hein updated this revision to Diff 13391.
hein added a comment.
Further disable hover effects for:
- Checkable group boxes.
- Checkboxes embedded into list items.
- Tree branch expander arrows.
I can now no longer find any occurences of hover effects in
oxygen-demo5 or System Se
hein updated this revision to Diff 13389.
hein added a comment.
Also disable hover effect on selected view items.
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5428?vs=13388&id=13389
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5428
AFFE
hein created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The Plasma distribution I work would prefer to disable most UI hover
effects and have the system behave more similar to systems such as
Mac OS
30 matches
Mail list logo
