This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e5574b458abb: Improve password dialogs (authored by
jgrulich).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5382?vs=13317&id=13565
REVIS
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
password-dialogs
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #vdg, #plasma, mart
Cc: fabianr, mart, broulik, plasma-devel, spstarr, pro
fabianr added a comment.
+1, other then the spacing mentioned above, I like the change.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #vdg, #plasma
Cc: fabianr, mart, broulik, plasma-devel, spstarr, progwolff, lesliezhai,
jgrulich added a comment.
In https://phabricator.kde.org/D5382#101684, @fabianr wrote:
> It looks like the spacing between the 4 content sections (title,
description, passwords, buttons) is not always the same. To me it the spacing
between title - description and password - buttons looks
fabianr added a comment.
It looks like the spacing between the 4 content sections (title, description,
passwords, buttons) is not always the same. To me it the spacing between title
- description and password - buttons looks equal, but description - password
seems to be smaller. I would sugg
mart added a comment.
+1 from me as well
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #plasma, #vdg
Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
jgrulich updated this revision to Diff 13317.
jgrulich added a comment.
Highlight connection name with bold text and add colon at the end of sentence
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5382?vs=13292&id=13317
BRANCH
pa
jgrulich added a comment.
In https://phabricator.kde.org/D5382#101074, @broulik wrote:
> I like!
>
> Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN*
connection" (ie. capital). Also, add a colon at the end "password below:"
Any suggestion what to use
broulik added a comment.
I like!
Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN*
connection" (ie. capital). Also, add a colon at the end "password below:"
(Is there a way to get rid of the "KDE Daemon" caption and replace it by
something more meaningful?)
jgrulich edited the summary of this revision.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
broulik added reviewers: Plasma, VDG.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #plasma, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Improve UI of all paswords dialogs. Previously we had two methods to setup UI
of the dialog, either for VPN or for regular connections like
12 matches
Mail list logo
