D5254: better layout and animate keyboard

2017-04-06 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7611f250cce6: better layout and animate keyboard (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5254?vs=13001&id=13146 REVISION DETAIL

D5254: better layout and animate keyboard

2017-04-06 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH phab/sddmkeyboard REVISION DETAIL https://phabricator.kde.org/D5254 To: mart, #plasma, davidedmundson, graesslin, broulik Cc: apol, plasma-devel, progwolff, lesliezhai,

D5254: better layout and animate keyboard

2017-03-30 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5254#99062, @apol wrote: > In https://phabricator.kde.org/D5254#99012, @mart wrote: > > > before: F3437115: keyboardwrong.png > > > > after: F3437117: keyboardok1.png

D5254: better layout and animate keyboard

2017-03-30 Thread Martin Gräßlin
graesslin added a comment. making the keyboard smaller is difficult as qt tries to be too smart. One can only specify the width. There is no control over the height. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5254 To: mart, #plasma, davidedmundson, gra

D5254: better layout and animate keyboard

2017-03-30 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5254#99062, @apol wrote: > In https://phabricator.kde.org/D5254#99012, @mart wrote: > > > before: F3437115: keyboardwrong.png > > > > after: F3437117: keyboardok1.png

D5254: better layout and animate keyboard

2017-03-30 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D5254#99012, @mart wrote: > before: F3437115: keyboardwrong.png > > after: F3437117: keyboardok1.png > > even less space: do without user list F3437120

D5254: better layout and animate keyboard

2017-03-30 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > Login.qml:15 > > +//the y position that should be ensured visible when the on screen > keyboard is visible > +property int visibleBoundary: mapFromItem(loginButton, 0, 0).y together with https://phabricator.kde.org/D4893, this property ma

D5254: better layout and animate keyboard

2017-03-30 Thread Marco Martin
mart added a comment. before: F3437115: keyboardwrong.png after: F3437117: keyboardok1.png even less space: do without user list F3437120: keyboardok2.png REPOSITORY

D5254: better layout and animate keyboard

2017-03-30 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Similar to https://phabricator.kde.org/D4893, use a state machine to track the status of the keyboard and animate the open/close. this improv