D5232: Add override to methods that override methods on their parent class

graesslin added a comment. In https://phabricator.kde.org/D5232#98698, @apol wrote: > In https://phabricator.kde.org/D5232#98689, @graesslin wrote: > > > I would prefer if this IMHO useless warning gets disabled. > > > `override` adds useful semantics to your code, that's never u

D5232: Add override to methods that override methods on their parent class

apol abandoned this revision. apol added a comment. In https://phabricator.kde.org/D5232#98689, @graesslin wrote: > I would prefer if this IMHO useless warning gets disabled. `override` adds useful semantics to your code, that's never useless. Oh well... REPOSITORY R108 KWi

D5232: Add override to methods that override methods on their parent class

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I would prefer if this IMHO useless warning gets disabled. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5232 To: apol, #plasma, graesslin, davidedm

D5232: Add override to methods that override methods on their parent class

luebking added a comment. In case you'd rather not want to introduce a git history wall: -Wno-inconsistent-missing-override -Wno-inconsistent-missing-destructor-override -Wno-initializer-overrides REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5232 To: apol, #plasma

D5232: Add override to methods that override methods on their parent class

apol created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY I was trying to compile kwin and it was impossible to read the output because clang complains if it should override and it doesn't So