rjvbb abandoned this revision.
rjvbb added a comment.
Closed with commit
https://commits.kde.org/oxygen/3677f75e956e1946cd0ee775ff2969d0b2ecf1c7
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D5186
To: rjvbb, hpereiradacosta
Cc: plasma-devel, #plasma, spstarr,
rjvbb set the repository for this revision to R113 Oxygen Theme.
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D5186
To: rjvbb, hpereiradacosta
Cc: plasma-devel, #plasma, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
rjvbb updated this revision to Diff 13755.
rjvbb added a comment.
Final version. Most of the forward declarations were actually redundant.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5186?vs=13702&id=13755
REVISION DETAIL
https://phabricator.kde.org/D5186
AFFECTED FILES
ksty
hpereiradacosta requested changes to this revision.
hpereiradacosta added a comment.
This revision now requires changes to proceed.
Implementation wise, perfect !
Some minor comments to be fixed, then ship it !
Thanks for the patch
INLINE COMMENTS
> oxygenstylechooser.cpp:37
> +#includ
rjvbb set the repository for this revision to R113 Oxygen Theme.
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D5186
To: rjvbb, hpereiradacosta
Cc: plasma-devel, #plasma, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
rjvbb updated this revision to Diff 13702.
rjvbb added a comment.
Simplified style selector widget that just shows the available styles and
"ticks" the currently active style.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5186?vs=12832&id=13702
REVISION DETAIL
https://phabricato
rjvbb added a comment.
In https://phabricator.kde.org/D5186#99745, @hpereiradacosta wrote:
> In any case, none of this is really necessary here: IMHO the menu should
just have the list of available styles (StyleFactory::keys()) and the "correct"
radiobox selected at startup.
> Wdyt ?
hpereiradacosta added a comment.
To be honest, I think all the dealing with default style, desktop style, bold
font, etc is superfluous and in fact misleading:
The "default" style can actually depend not only on the OS, but on the
distribution, etc.
Also the return of "cg.readEntry( "wi
rjvbb created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds the widget style chooser evoked during the colour scheme chooser
review (https://phabricator.kde.org/D5113).
REPOSITORY
R113 Oxygen
