This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bc33f0470d4d: Set implicit size from source size for
image/SVG URL sources. (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D51
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5160
To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, al
drosca added a comment.
You don't reset the implicitSize anywhere, so if you do setSource(QImage) and
then setSource(QIcon) it will still have the implicitSize of the previously set
QImage.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5160
To:
hein updated this revision to Diff 12755.
hein added a comment.
Always update implicit size.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5160?vs=12752&id=12755
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5160
AFFE
hein added a comment.
That was me being sleepy and trying to be smart and cunning and avoid
busywork :)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5160
To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff,
hein added a dependent revision: D5162: Port custom image mode to IconItem..
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5160
To: hein, #plasma, mart, davidedmundson
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg
hein created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This allows users of IconItem to know the aspect ratio of the
source document, which can be used to size the item or set
applet size
