This revision was automatically updated to reflect the committed changes.
Closed by commit R108:a7b7ce9ec07a: new logout effect (authored by mart).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5045?vs=12487&id=12494
REVISION DETAIL
https://phabricator.kde.org
graesslin added a comment.
In https://phabricator.kde.org/D5045#95099, @mart wrote:
> In https://phabricator.kde.org/D5045#95005, @graesslin wrote:
>
> > Please do not delete the shaders! They are still used by the blur effect
for cheap fullscreen blur!
>
>
> ouch, didn't knew,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
arcpatch-D5045
REVISION DETAIL
https://phabricator.kde.org/D5045
To: mart, graesslin, #plasma
Cc: broulik, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed,
jensreu
mart updated this revision to Diff 12487.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
add logout in tests
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5045?vs=12464&id=12487
BRANCH
arcpatch-D5045
REVISION DET
mart added a comment.
In https://phabricator.kde.org/D5045#95005, @graesslin wrote:
> Please do not delete the shaders! They are still used by the blur effect
for cheap fullscreen blur!
ouch, didn't knew, sorry :(perhaps would be better to move them in like a
sharedshaders folder
graesslin added a comment.
Please do not delete the shaders! They are still used by the blur effect for
cheap fullscreen blur!
INLINE COMMENTS
> main.js:28
> +var windowClass = window.windowClass;
> +if (windowClass === "ksmserver ksmserver") {
> +return true;
is
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
When adding a new effect the auto tests for the effect loader need to be
adjusted as otherwise it fails because it finds effects it doesn't know of.
REPOSITORY
R108 KWin
broulik added inline comments.
INLINE COMMENTS
> main.js:24
> +var logoutEffect = {
> +duration: animationTime(800),
> +isLogoutWindow: function (window) {
Connect to configurationChanged and update that time then (done in all other
effects)
REPOSITORY
R108 KWin
REVISION DETAIL
ht
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
new logout effect: it's just a slow fade in of the logout
greeter (window is usable immediately tough
TEST PLAN
logout greeter now f
