This revision was automatically updated to reflect the committed changes.
Closed by commit R122:29c3c91c56d0: Get rid of QWeakPointer (authored by
denisshienkov, committed by mart).
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4970?vs=12331&id=12425
REVI
mart added a comment.
pushed the patch.
you are encouraged anyways to apply for a developer account!
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson
Cc: mart, davidedmundson, plasma-devel, volkov
mart added a comment.
pushed the patch, you are encouraged anyways to get a developer account!
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson
Cc: mart, davidedmundson, plasma-devel, volkov, progwo
volkov added a comment.
https://community.kde.org/Infrastructure/Get_a_Developer_Account
"After you obtained your KDE Identity, visit the Developer Application page
to apply for a KDE Developer Account."
"Normally, any developer who has done some work on projects hosted by KDE can
appl
denisshienkov added a comment.
Can I get a "commit access"? If yes, then how? I have read many WiKi's pages
about KDE commit policy and so on.. But I did not understand how it works with
KDE? Could you please recommend for me some appropriate wiki?
PS: I know how to work with Qt's JIRA,
aacid resigned from this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Ok, abstaining.
David you should commit it since AFAICS Denis does not have commit access.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: deni
cfeck set the repository for this revision to R122 Powerdevil.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson, aacid
Cc: aacid, davidedmundson, plasma-devel, volkov, progwolff, lesliezhai,
ali-mohame
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
What repository is this patch for?
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson, aacid
Cc: aacid, davidedmundson
denisshienkov added a comment.
What is next steps from my side?
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson
Cc: davidedmundson, plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson
Cc: davidedmundson, plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
denisshienkov updated this revision to Diff 12331.
denisshienkov edited the summary of this revision.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4970?vs=12270&id=12331
REVISION DETAIL
https://phabricator.kde.org/D4970
AFFECTED FILES
kcmodule/activities/activitypage.cpp
kcmodu
davidedmundson added a comment.
>> From the the documentation of QObject::~QObject: "Warning: Deleting a
QObject while pending events are waiting to be delivered can cause a crash."
>
> It can happens only if an object lives in a different thread. But the
ErrorOverlay - is a widget, whic
denisshienkov added a comment.
It can happens only if an object lives in a different thread. But the
ErrorOverlay - is a widget, which should live in a main thread.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov
volkov added a comment.
From the the documentation of QObject::~QObject: "Warning: Deleting a QObject
while pending events are waiting to be delivered can cause a crash."
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano,
denisshienkov added a reviewer: ltoscano.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, volkov, afiestas, ltoscano
Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
denisshienkov added a reviewer: afiestas.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, volkov, afiestas
Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
denisshienkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As it is overhead to use QWeakPointer and QPointer in this simple code. Also,
now we delete the ErrorOverlay objects directly instead of
denisshienkov added a reviewer: volkov.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, volkov
Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
18 matches
Mail list logo
