D4869: [Notifications Dataengine] Create KConfig object on the stack

2017-03-08 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:891d8a3bcb23: [Notifications Dataengine] Create KConfig object on the stack (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4869?vs=1

[Differential] [Accepted] D4869: [Notifications Dataengine] Create KConfig object on the stack

2017-03-01 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4869 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, prog

[Differential] [Request, 8 lines] D4869: [Notifications Dataengine] Create KConfig object on the stack

2017-03-01 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I don't see why it should be created on the heap. TEST PLAN Did a spectacle notificaton, still got the configure button and it still worked