This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3b05f569ac29: Split frag and vert code of FadingNode into
separate files (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
mart accepted this revision.This revision is now accepted and ready to land.
View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4848EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: davidedmundson, Plasma, martCc: mart, b
davidedmundson added a dependent revision: D4851: Implement FadingMaterial
frag/vert shaders on core profile.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4848
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: da
davidedmundson updated this revision to Diff 12000.
davidedmundson added a comment.
Change prefix
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4848?vs=11980&id=12000
REVISION DETAIL
https://phabricator.kde.org/D4848
AFFECTED FILES
mart added a comment.
agree on plasma-framework, in general, looks way cleaner :)
INLINE COMMENTS
> broulik wrote in shaders.qrc:2
> plasma-framework?
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4848
EMAIL PREFERENCES
https://phabricato
broulik added a comment.
+1
INLINE COMMENTS
> fadingnode.cpp:57
> {
> -return "varying highp vec2 v_coord;"
> -"uniform sampler2D u_src;"
> -"uniform sampler2D u_target;"
> -"uniform highp float u_transitionProgress;"
> -"uniform lowp float qt_Opacity;"
> -"void main(
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This matches what Qt does internally, it's easier to read and gives us
syntax highlighting on the shader files,
