D4838: [Notifications] Add context menu for thumbnail

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f98a90df2541: [Notifications] Add context menu for thumbnail (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4838?vs=11939&id=12330#toc REPOSITORY R120 Plasma Workspace

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. Final comment: Do whatever makes sense, keep only the context menu if you like. I'm out. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91404, @Fuchs wrote: > > As far as I was informed on IRC, as far as I can see in the very discussion here: context menus were discouraged. Ah right, that was a miscommunication on our side. I'd never discoura

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

Fuchs added a comment. In https://phabricator.kde.org/D4838#91385, @colomar wrote: > > Okay, personal opinion on why split buttons are among the most horrible things related to UX: > > (And whilst some of these points might not apply to this very specific use case here: they will else

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91286, @mart wrote: > i don't see the split button a very feasible option on a technical standpoint (and pretty bad purely on aestetics, would also be a thing we use only here and visually clashes with a combobox) If a

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. > Okay, personal opinion on why split buttons are among the most horrible things related to UX: > (And whilst some of these points might not apply to this very specific use case here: they will elsewhere, and once one component users this button, others will

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

mart added a comment. i don't see the split button a very feasible option on a technical standpoint (and pretty bad purely on aestetics, would also be a thing we use only here and visually clashes with a combobox) those extra actions are not a fundamental thing at all, and i would not part

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

Fuchs added a comment. In https://phabricator.kde.org/D4838#91010, @colomar wrote: > In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > > > I thought of something like this: F2668672: Screenshot_20170228_114914.png > > Is this in li

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. And if it's not an "Open" button? The action is provided by the application itself, after all. It might not add it (I actually want to get rid of it as we now have the preview area) or have it do something different than it does now. There could also be multiple. RE

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91004, @broulik wrote: > > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. > > S

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > I thought of something like this: F2668672: Screenshot_20170228_114914.png > Is this in line with the HIG? That's the idea we've discussed above and yes

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

subdiff added a comment. I thought of something like this: F2668672: Screenshot_20170228_114914.png Is this in line with the HIG? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabr

[Differential] [Abandoned] D4838: [Notifications] Add context menu for thumbnail

broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg Cc: subdiff, colomar, plasma-devel, progwolff, lesliezhai, ali-moha

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. So, how can I access the menu options for the invidiaual files, here?

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#90994, @broulik wrote: > > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. > > Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in its menus, neither the file actions (compress, activities, send to, e

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. > You don't have that in a file manager, either, and this thing represents a file. A file manager has a menu bar, however, so the context menu is never the only means to execute an action. I don't see how turning the Open button into a split button would "te

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > which makes sense to me because not every user will know about the possibility to do a right click. You don't have that in a file manager, either, and this thing represents a file. Even more so if there's multiple files, they'll show up as square items. I know

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

subdiff added subscribers: colomar, subdiff. subdiff added a comment. That's an awesome idea Kai! I normally only want to open the containing folder and not the screenshot directly, so I was really missing this functionality. Would it be a good idea to not make this as a right click context

[Differential] [Updated, 83 lines] D4838: [Notifications] Add context menu for thumbnail

broulik updated this revision to Diff 11939. broulik edited the test plan for this revision. broulik added a comment. - Add "Copy" action REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4838?vs=11937&id=11939 REVISION DETAIL https://phabricator.k

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed

[Differential] [Request, 66 lines] D4838: [Notifications] Add context menu for thumbnail

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since it represents a file, right clicking it should provide similar options found in a file manager. This allows to open the application wi