D4347: Avoid jumpy UI in Kicker Dialogs

2017-08-30 Thread David Edmundson
davidedmundson abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4347 To: davidedmundson, #plasma, hein Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

[Differential] [Commented On] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread Eike Hein
hein added a comment. For posterity: While the code looked OK to me, as talked about on IRC, the patch doesn't work for me. It actually makes things worse for now. Without the patch I get the "one bad frame during dialog resize" glitch while roving through the root level menu intermittently,

[Differential] [Changed Subscribers] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > submenu.cpp:33 > { > - KWindowSystem::setType(winId(), NET::Menu); > +setType(Dialog::Dock); > } why is it changed to Dock? A Dock is not a menu and this could have side-effects in how KWin manages the window. REPOSITORY R119 Plasma

[Differential] [Accepted] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread Eike Hein
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4347 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Request, 37 lines] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Under X11 we would see move events as two distinct jumpy frames. The Dialog would move, and t