D4220: Add a basic SNI for keyboard layout

bam added a comment. Not a revert but rather rollback of SNI part: https://invent.kde.org/plasma/kwin/-/merge_requests/560 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4220 To: graesslin, #plasma_on_wayland, #kwin, davidedmundson Cc: bam, davidedmundson, luebking,

D4220: Add a basic SNI for keyboard layout

bam added a comment. We are going to revert this in favor of https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/181: it supports all the existing functional here plus missing one (problem with short layout names was solved): - flags and/or short text for the layouts If

[Differential] [Closed] D4220: Add a basic SNI for keyboard layout

This revision was automatically updated to reflect the committed changes. Closed by commit R108:fe561c5c7def: Add a basic SNI for keyboard layout (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4220?vs=10427&id=10539#toc REPOSITORY R108 KWin CHANGES SINCE LAST

[Differential] [Accepted] D4220: Add a basic SNI for keyboard layout

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH keyboard-layout-sni REVISION DETAIL https://phabricator.kde.org/D4220 EMAIL PREFERENCES https://phabricator.kde.org/settin

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in keyboard_layout.cpp:142 > You only want this in ::reconfigure() before resetLayout and not here. > > You're calling this method from reconfigure and in processKeymapChange, from > keyboard_input - that won't affect wheth

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

davidedmundson added a comment. One comment, but otherwise ship it. That contextMenu thing will come back to haunt us in the future, but hopefully SNI will be fixed by then. INLINE COMMENTS > keyboard_layout.cpp:142 > m_layout = m_xkb->currentLayout(); > +initNotifierItem(); >

[Differential] [Updated] D4220: Add a basic SNI for keyboard layout

graesslin added a dependent revision: D4256: Support global shortcut to switch to specific layout. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_waylan

[Differential] [Updated, 197 lines] D4220: Add a basic SNI for keyboard layout

graesslin updated this revision to Diff 10427. graesslin added a comment. Translate layout names REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4220?vs=10395&id=10427 BRANCH keyboard-layout-sni REVISION DETAIL https://phabricator.kde.org/D4220 AFFECTED

[Differential] [Updated, 197 lines] D4220: Add a basic SNI for keyboard layout

graesslin updated this revision to Diff 10395. graesslin added a comment. Support config option for show/hiding the sni REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4220?vs=10391&id=10395 BRANCH keyboard-layout-sni REVISION DETAIL https://phabricator.k

[Differential] [Updated, 151 lines] D4220: Add a basic SNI for keyboard layout

graesslin updated this revision to Diff 10391. graesslin added a comment. Scroll support REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4220?vs=10382&id=10391 BRANCH keyboard-layout-sni REVISION DETAIL https://phabricator.kde.org/D4220 AFFECTED FILES

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added a comment. In https://phabricator.kde.org/D4220#78887, @luebking wrote: > In https://phabricator.kde.org/D4220#78878, @graesslin wrote: > > > > > > > > > This change is about the opposite: supporting *changing* the layout. Not about notifying the layout chang

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

luebking added a comment. In https://phabricator.kde.org/D4220#78878, @graesslin wrote: > > This change is about the opposite: supporting *changing* the layout. Not about notifying the layout change, that is something we already support for at least a year. Yes. Afai

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added inline comments. INLINE COMMENTS > graesslin wrote in keyboard_layout.cpp:182 > uh nice, didn't know that and followed the existing code too blindly. This doesn't work :-( I added the actions, but the menu doesn't get shown at all. REPOSITORY R108 KWin REVISION DETAIL http

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added a comment. > I'll raise a fundamental question: is wayland prone to end up being Yes, we are renaming kwin to kwind :-) > it may need an interface in such occasions, signalling the change, exposing the layout and allow clients to alter the layout. Yes, that's b

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in keyboard_layout.cpp:165 > so KToolInvocation::startServiceByName()? yes, except that we used to use KToolInvocation and ported away from it. Something - in the case of KWin - doesn't work for it. The standard case of KW

[Differential] [Changed Subscribers] D4220: Add a basic SNI for keyboard layout

davidedmundson added inline comments. INLINE COMMENTS > keyboard_layout.cpp:165 > +[this] { > +// TODO: introduce helper function to start kcmshell5 > +QProcess *p = new Process(this); so KToolInvocation::startServiceByName()? > keyboard_layout.cpp:182 > + > +

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

luebking added a comment. "On Wayland that kded has no real access to the layouts and cannot properly implement switching. Given that it's better to integrate the SNI directly in KWin." I'll raise a fundamental question: is wayland prone to end up being PID 0: systemd PID 1: kwin

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added a comment. F2090291: keyboard-kded.png REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland

[Differential] [Request, 123 lines] D4220: Add a basic SNI for keyboard layout

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On X11 the SNI for keyboard layout is provided by the keyboard kded.