D4034: Show descriptive text when changing containment plugins

rooty added a comment. nice! props REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 To: davidedmundson, #plasma, mart Cc: ngraham, rooty, broulik, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4034: Show descriptive text when changing containment plugins

ngraham added a comment. In D4034#349125 , @rooty wrote: > hey guys don't get mad at me for the necropost (and the nitpicking) but... it really should be "while", not "whilst" for users that use en_US, for the sake of consistency You are

D4034: Show descriptive text when changing containment plugins

rooty added a comment. hey guys don't get mad at me for the necropost (and the nitpicking) but... it really should be "while", not "whilst" for users that use en_US, for the sake of consistency REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 To: davided

[Differential] [Accepted] D4034: Show descriptive text when changing containment plugins

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. let's go for it, tough i really fear the pain a real solution may be :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.

[Differential] [Closed] D4034: Show descriptive text when changing containment plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3851de096f02: Show descriptive text when changing containment plugins (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4034?vs=9886&id=10057#toc REPOSITORY R119 P

[Differential] [Commented On] D4034: Show descriptive text when changing containment plugins

broulik added a comment. +1 INLINE COMMENTS > ConfigurationContainmentAppearance.qml:95 > +visible: configDialog.containmentPlugin != root.containmentPlugin > +Text { > +Layout.fillWidth: true use QQC Label (note the different font rendering in this label compared

[Differential] [Commented On] D4034: Show descriptive text when changing containment plugins

davidedmundson added a comment. > the possible problem, is still the user changing the other stuff before, like wallpaper, and then without pressing apply changes the layout, that would still not be covered i think Yeah, that problem is still there, but it's no worse than the current sta

[Differential] [Commented On] D4034: Show descriptive text when changing containment plugins

mart added a comment. i'm not sure if it's worth to change the architecture for a thing that's used very rarely even if it's implementation bleeding over to ui, that's fine. the possible problem, is still the user changing the other stuff before, like wallpaper, and then without pressi

[Differential] [Commented On] D4034: Show descriptive text when changing containment plugins

davidedmundson added a comment. Screenshot after changing plugin type F1968769: Spectacle.C16867.png restoring previous value restores contents REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 EMAIL PREFEREN

[Differential] [Request, 30 lines] D4034: Show descriptive text when changing containment plugins

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When one changes containment plugin, the rest of the configuration options don't apply or in