D3598: rework kscreen's OSD logic

sebas abandoned this revision. sebas added a comment. This branch is going to be merged as part of https://phabricator.kde.org/D9414 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3598 To: sebas, #plasma Cc: kpiwowarski, mart, graesslin, broulik, plasma-devel, david

D3598: rework kscreen's OSD logic

sebas planned changes to this revision. sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in osd.cpp:38 > you're not getting and look and feel / theming in here. We do get theming, but not the OSD from the Look and Feel package. I feel it's overkill to include this in the Look

[Differential] [Commented On] D3598: rework kscreen's OSD logic

sebas added a comment. Correct, that's the idea. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3598 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: mart, graesslin, broulik, plasma-devel, davidedmundson, lesl

[Differential] [Commented On] D3598: rework kscreen's OSD logic

mart added a comment. In https://phabricator.kde.org/D3598#67455, @sebas wrote: > protocol), we'll move this code into its own daemon and kwin will authorize that daemon. THat's basically the same approach we'll have to take with powerdevil. so in the end the authorized process w

[Differential] [Commented On] D3598: rework kscreen's OSD logic

broulik added a comment. A bunch of nitpicks below. Haven't tried it yet, though :) Is there a chance we could serve the novice user usecase of Meta+P and then *click* / choose the desired setup? As far as I can tell we only show "You now use $setup" but not "You can choose: [Clone, Left

[Differential] [Updated] D3598: rework kscreen's OSD logic

sebas marked an inline comment as done. sebas added a subscriber: graesslin. sebas added a comment. I actually talked about this with @graesslin, and this is the solution we came up with. When we limit the number of processes that are allowed to talk specific protocols to the Wayland server (

[Differential] [Commented On] D3598: rework kscreen's OSD logic

davidedmundson added a comment. It has the future wayland problem that MG wants to limit which applications can access which interfaces; you're implicitly using a plasma specific one in Dialog to position the window, which would make kded need to be a "trusted application" So whatever t

[Differential] [Updated, 820 lines] D3598: rework kscreen's OSD logic

sebas updated this revision to Diff 8796. sebas marked 15 inline comments as done. sebas added a comment. - improve osd test app - call the dbus service from the test app - also register the service - Addressing Kai's review, part 1 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3598: rework kscreen's OSD logic

sebas added inline comments. INLINE COMMENTS > broulik wrote in osd.cpp:120 > Compare with QL1S - in case you have KWindowSystem you can ask it We only have KWindowSystem implicitly, I'm going with the QGuiApplication::platformName() comparison (changed to QL1S). > broulik wrote in osdmanager.

[Differential] [Request, 763 lines] D3598: rework kscreen's OSD logic

sebas created this revision. sebas added a reviewer: Plasma. sebas added a subscriber: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This changeset moves the various OSDs used in kscreen (output identifie