mpartap added a comment.
> This [configurable scrollbar size] was deemed unnecessary
In a discussion with a very select audience, which neither seem to suffer
from a HiDPI setup or limited visual ability.
Few people among those who experience discomfort with a current
implementation tr
hpereiradacosta added a comment.
In https://phabricator.kde.org/D3210#83622, @anthonyfieroni wrote:
> We ends with no configurable scrollbar size at all, it has plan for this
*really* ?
Indeed. This was deemed unnecessary (see discussion above), with respect to
the added code com
anthonyfieroni added a comment.
We ends with no configurable scrollbar size at all, it has plan for this
*really* ?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D3210
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
This revision was automatically updated to reflect the committed changes.
Closed by commit rBREEZE850ed6dd0a77: make scrollbar size configurable
(authored by mart).
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=8204&id=8205
REVISION DETAIL
https:
mart updated this revision to Diff 8204.
mart added a comment.
- Merge branch 'master' into arcpatch-D3210
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=8202&id=8204
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/D3210
A
mart updated this revision to Diff 8202.
mart added a comment.
- move the metrics back to the breeze.h header
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=8152&id=8202
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/D3210
hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.
As far as I am concern, I think we are safe: new design, but same
functionality. I am ready to answer bug reports and justify the change if
needed. And if there are two m
colomar added a comment.
I haven't had the chance to play with it and I think we should still have a
plan B if we get negative feedback on it during beta tests, but the concept as
it is described in the latest comments makes sense to me.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https:/
mart updated this revision to Diff 8152.
mart added a comment.
- bigger hit area
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=8151&id=8152
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/D3210
AFFECTED FILES
kstyle/bre
hpereiradacosta added a comment.
In https://phabricator.kde.org/D3210#62696, @mart wrote:
> this version always has a small scrollbar, show on hover enabled when
animations are enabled
+1 for me.
Personally, I would leave the _scrollBar_Extend to 20, to have the same hit
are
mart added a comment.
this version always has a small scrollbar, show on hover enabled when
animations are enabled
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3210
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #pla
mart updated this revision to Diff 8151.
mart added a comment.
- always small scrollbar
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=8094&id=8151
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/D3210
AFFECTED FILES
kst
hpereiradacosta added a comment.
I fear there is still some misunderstanding here. Maybe it is due to the
original animation send for the other modification.
Maybe to make it clear to colomar:
for a vertical scrollbar, the current animation does _not_ change the width
of the scrollbar. T
mart updated this revision to Diff 8094.
mart added a comment.
- tie the new scrollbar style to animations enabled
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=8093&id=8094
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/
mart added a comment.
done. It looks maybe a bit too "magic", but may be a good thing
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3210
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, #vdg, hpereiradacosta
Cc:
mart updated this revision to Diff 8093.
mart added a comment.
- tie the new scrollbar style to animations enabled
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=7870&id=8093
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/
colomar added a comment.
In https://phabricator.kde.org/D3210#62062, @mart wrote:
>
> sorry for the late reply
> ok, so if i understood correctly:
> I'll remove those 2 options, and have instead both showing the scrollbar
on hover *and* the scrollbar size depend unique
mart added a comment.
In https://phabricator.kde.org/D3210#61533, @colomar wrote:
> Whoa okay, that is complex...
> Given that I failed to understand what the proposed checkboxes were
supposed to mean, I fear it will be the same for users.
> Therefore maybe not gibing the option at
colomar added a comment.
Whoa okay, that is complex...
Given that I failed to understand what the proposed checkboxes were supposed
to mean, I fear it will be the same for users.
Therefore maybe not gibing the option at all is indeed the better solution,
and your suggestion to turn the fe
hpereiradacosta added a comment.
Hi Colomar,
no usability problem no. (at worst some miswording, and misunderstanding)
In https://phabricator.kde.org/D3210#61496, @colomar wrote:
> In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote:
>
> >
>
>
>
>
> >
colomar added a comment.
In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote:
>
>> Why do we need both? What happens if one checks the first but not the
second?
>
> You get a large scrollbar, visible only on mouse-over
So that means it would be compl
mart added a comment.
In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote:
> Which is why I think "no" option would actually be better.
> In other word, either you have 2 checkboxes that cover all four possible
combinations, or you start to make arbitrary (design based)
hpereiradacosta added a comment.
In https://phabricator.kde.org/D3210#60962, @colomar wrote:
> In https://phabricator.kde.org/D3210#60602, @mart wrote:
>
> >
>
>
> in this latest version there are 2 checkboxes: "show scrollbar only on
mouse over" and "small scrollbar" which bo
colomar added a comment.
In https://phabricator.kde.org/D3210#60602, @mart wrote:
>
in this latest version there are 2 checkboxes: "show scrollbar only on mouse
over" and "small scrollbar" which both defautls to true
Why do we need both? What happens if one checks the first b
mart added a comment.
In https://phabricator.kde.org/D3210#60493, @colomar wrote:
> If I understood it correctly (that there is only a checkbox "Only show full
scrollbar on mouse over" added to the config) then that is exactly what I had
in mind.
in this latest version there are
colomar added a comment.
If I understood it correctly (that there is only a checkbox "Only show full
scrollbar on mouse over" added to the config) then that is exactly what I had
in mind.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3210
EMAIL PREFERENCES
ht
mart updated this revision to Diff 7870.
mart added a comment.
- make the scrollbar size config a simple checkbox
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3210?vs=7783&id=7870
BRANCH
arcpatch-D3210
REVISION DETAIL
https://phabricator.kde.org/D
hpereiradacosta added a comment.
> personally, (and would be good if thomas, jens or alex from the cdg weigh
on that) I would have the default as:
>
> - small scrollbar
> - show on mouseover enabled
> - no arrow buttons
+1 on this.
Been using this setup for few days now a
mart added a comment.
In https://phabricator.kde.org/D3210#60230, @hpereiradacosta wrote:
> So, just to make sure I understand:
>
> - 1 option to "only show full scrollbar on mouse over" (as we have now)
> - 1 option to "use slim scrollbar" (with reduced width handle) Is that what
y
hpereiradacosta added a comment.
In https://phabricator.kde.org/D3210#60184, @colomar wrote:
> It does make sense to me to give the option to turn the slim scroll bar as
such on and off. I can imagine some people being uncomfortable with the
animation on mouseover.
> Being able to con
colomar added a comment.
It does make sense to me to give the option to turn the slim scroll bar as
such on and off. I can imagine some people being uncomfortable with the
animation on mouseover.
Being able to configure individual parameters is probably overkill, however.
REPOSITORY
rBRE
hpereiradacosta added a comment.
One screenshot, with the metrics suggested above:
http://wstaw.org/m/2016/11/02/plasma-desktopna2488.png
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3210
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
hpereiradacosta added a comment.
Hello again Marco,
Over the week-end I have used (and experienced with) the proposed slim
scrollbar, and I must say I has grown on me quite some.
However I'd like to propose a slightly different metrics for the reduce
scrollbar, which you could possibly t
alex-l added a comment.
I'd like to have the options if possible. I don't think we will lose
consistency. Other parts of Breeze provide options like buttons in title bar
size, order etc.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3210
EMAIL PREFERENCES
htt
hpereiradacosta added a comment.
Hello Marco,
Thanks for the patch.
1/ On the implementation side: I have tried so far to keep all the magic
numbers for breeze (and oxygen) in Breeze::Metrics, because it makes
maintainability much easier. I think it should stays so, and not become split
mart updated this revision to Diff 7783.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
- Merge branch 'master' into arcpatch-D3210
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
36 matches
Mail list logo
