alex updated this revision to Diff 83029.
alex marked an inline comment as done.
alex added a comment.
Create test cases
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29807?vs=83028&id=83029
BRANCH
api_inconsistencies (branched from master)
RE
alex updated this revision to Diff 83028.
alex added a comment.
Make constructor private
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29807?vs=83019&id=83028
BRANCH
api_inconsistencies (branched from master)
REVISION DETAIL
https://phabrica
anthonyfieroni added reviewers: broulik, Plasma.
anthonyfieroni added a comment.
Commented code should be removed.
INLINE COMMENTS
> chromeprofile.h:11
> +public:
> +ProfileBookmarks(const QString &path, const QString &name);
> +static QList findAllProfiles(const QString
> &applicati
alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
- The FindProfile class was only for Chrome implemented => removed
- Having ProfileBookmarks and Profile class is unnecessary, especiall
