D29807: Change Chrome API design

meven added a comment. In D29807#675032 , @alex wrote: > Friendly Ping :-) > > Or should I just move this to gitlab? This is close to be approved, no need to move this. I think this can land @broulik @ngraham ? INLINE COMMENTS

D29807: Change Chrome API design

alex added a comment. Friendly Ping :-) Or should I just move this to gitlab? REPOSITORY R120 Plasma Workspace BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabricator.kde.org/D29807 To: alex, broulik, #plasma, ngraham, meven Cc: anthonyfieroni, plasm

D29807: Change Chrome API design

meven accepted this revision. meven added a comment. @broulik perhaps a review ? REPOSITORY R120 Plasma Workspace BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabricator.kde.org/D29807 To: alex, broulik, #plasma, ngraham, meven Cc: anthonyfieroni, plasma-

D29807: Change Chrome API design

alex updated this revision to Diff 83131. alex added a comment. Use iterator, remove unused include REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83118&id=83131 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https

D29807: Change Chrome API design

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Two smalls things. Seems good to me otherwise. Give some times to other to have a final say before merging. INLINE COMMENTS > chromeprofile.cpp:33 > +const QStringList

D29807: Change Chrome API design

alex updated this revision to Diff 83118. alex added a comment. Formatting, remove debug statement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83116&id=83118 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https:

D29807: Change Chrome API design

meven added a comment. Seems good, two small clean ups INLINE COMMENTS > chromeprofile.cpp:8 > +ProfileBookmarks::ProfileBookmarks(const QString &path, const QString &name) > +: m_path(path), m_name(name), m_favicon(nullptr) { > +// Remove "Bookmarks" from end of path `{` on new line

D29807: Change Chrome API design

alex updated this revision to Diff 83116. alex retitled this revision from "WIP: Change Chrome API design" to "Change Chrome API design". alex edited the summary of this revision. alex added reviewers: ngraham, meven. alex added a comment. Change import, formatting REPOSITORY R120 Plasma Wo