D2975: [shell] Event compress resizePanel

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes to remove from queue pending reply to Kai's question REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

D2975: [shell] Event compress resizePanel

broulik added a comment. View RevisionIs this obsolete then?REPOSITORYR120 Plasma WorkspaceREVISION DETAILhttps://phabricator.kde.org/D2975EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: bshah, PlasmaCc: broulik, mart, hein, plasma-devel, progwolff, lesliezhai, ali-

[Differential] [Updated] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55717, @bshah wrote: > In https://phabricator.kde.org/D2975#55709, @mart wrote: > > > ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55709, @mart wrote: > ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues, we reconsider this one again? Okay looking onto it. REPO

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

mart added a comment. ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues, we reconsider this one again? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2975

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55706, @mart wrote: > adding an event compression timer (that by the way, it's a perfectly fine, many times even desired thing) and solving the useless restore() calls at startup are two ortogonal pissues. Double restore

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

mart added a comment. adding an event compression timer (that by the way, it's a perfectly fine, many times even desired thing) and solving the useless restore() calls at startup are two ortogonal pissues. an event compression there *may* be a good thing if during the normal use (like, dra

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

bshah added a comment. In https://phabricator.kde.org/D2975#55224, @mart wrote: > can it use QQmlParserStatus instead? Idea of using QQmlParserStatus is fine and it might save some cycles at start but problem remains same when I move panel around.. I don't think QQmlParser status

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

mart added a comment. can it use QQmlParserStatus instead? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2975 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma Cc: mart, hein, plasma-devel, les

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

hein added a comment. 100% no. Timers with magic timeout values are a "let's hope it works out if we wait a bit" anti-pattern to paper over figuring out proper update logic. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2975 EMAIL PREFERENCES

[Differential] [Request, 18 lines] D2975: [shell] Event compress resizePanel

bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At startup and as well when one moves panel, resizePanel is called multiple times. For instance, at startup res