ivan added a comment.
Done. Thanks again for the patch!
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D29595
To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himc
ivan closed this revision.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D29595
To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, j
ngraham added a comment.
@ivan are you gonna land this, or should I?
REPOSITORY
R845 Plasma Vault
BRANCH
add-gocryptfs-support (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29595
To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-
ngraham added inline comments.
INLINE COMMENTS
> ivan wrote in vaultwizardbase.h:65
> Heh, it was my first impression when the priority patch was contributed to
> Vaults. Now I'm extra careful :)
Perhaps the unintuitive nature of the numbering could be clarified with a
comment in a follow-up p
ivan added inline comments.
INLINE COMMENTS
> mpilia wrote in vaultwizardbase.h:65
> Of course, sorry. For some reason I though 1 was highest priority.
Heh, it was my first impression when the priority patch was contributed to
Vaults. Now I'm extra careful :)
REPOSITORY
R845 Plasma Vault
RE
mpilia added inline comments.
INLINE COMMENTS
> ivan wrote in vaultwizardbase.h:65
> Lower the priority to 1.
>
> I don't want to have gocryptfs as the default. At least for the time being.
Of course, sorry. For some reason I though 1 was highest priority.
REPOSITORY
R845 Plasma Vault
REVIS
mpilia updated this revision to Diff 82601.
mpilia added a comment.
Fix priority for gocryptfs
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29595?vs=82425&id=82601
BRANCH
add-gocryptfs-support (branched from master)
REVISION DETAIL
https://phab
ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.
Great work!
INLINE COMMENTS
> vaultwizardbase.h:65
> +{ "cryfs", 2 },
> +{ "gocryptfs", 3 },
> };
Lower the priority to 1.
I don't want to have gocryptfs as the
ngraham added reviewers: ivan, Plasma.
ngraham added a comment.
Very cool!
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D29595
To: mpilia, ivan, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, rag
mpilia created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mpilia requested review of this revision.
REVISION SUMMARY
Implement basic support for gocryptfs backend.
BUG: 398323
REPOSITORY
R845 Plasma Vault
BRANCH
add-gocryptfs-support (branc
10 matches
Mail list logo
