D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma, ngraham Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, les

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'll fix that for you and land this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma, ngraham Cc: ndavis, ngraham, plasm

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Overall it works very well given the current plumbing here! I'll accept it after one little change: INLINE COMMENTS > touchpad.qml:294 > + > +Controls.SpinBox { > +id: accelSpeedSpinbox Can you set `Layouts.Layout.minimumWidth: Kirigami.U

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Sorry for the delay in reviewing this. It's on my to-do list. I'll try to make some time today (it is a national holiday in my country). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngr

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. @ngraham is there an admin that can review this or should I abandon and make a MR on gitlab? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-F

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Thanks for your work. Will re-review soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 82966. kurmikon added a comment. Diff updated to a better version. So, I'm explaining what happens here. A RowLayout is placed where the old slider was. This contains a new slider and an additional spinbox. The spinbox gets float values by the u

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#671289 , @ngraham wrote: > Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using b

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using bindings properly. So you'll have to manually set both anywhere the slider's value is

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#671270 , @ngraham wrote: > Actually sorry, I won't get to that refactor soon so I don't want to block your work. > > Is this reviewable in its current state? Can you explain how I can improve this c

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Actually sorry, I won't get to that refactor soon so I don't want to block your work. Is this reviewable in its current state? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham,

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. The latter, if you don't mind. I appreciate your patience! I hope to have the rewrite submitted tomorrow. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGa

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#40 , @ngraham wrote: > Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a few days until that's done, it might make your patch a lot simpler. REPOSITORY R11

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 82323. kurmikon added a comment. So I worked on this. It's not easy to me to do this stuff since the slider and the spinbox have to synchronize themselves on the other one. Making symply and update from one to another would lead to infinite loop

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Yep, exposing the real values there is probably fine. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, f

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#664091 , @ngraham wrote: > I like @ndavis's idea of using a slider and a spinbox. The slider can be used for coarse adjustment, while the spinbox can be used for fine-tuning and have a very fine step size. I t

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. I like @ndavis's idea of using a slider and a spinbox. The slider can be used for coarse adjustment, while the spinbox can be used for fine-tuning and have a very fine step size. I think that would work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://pha

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663827 , @ndavis wrote: > I had a look at the documentation for libinput pointer acceleration (https://wayland.freedesktop.org/libinput/doc/latest/pointer-acceleration.html). For anyone following this conversa

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ndavis added a comment. I had a look at the documentation for libinput pointer acceleration (https://wayland.freedesktop.org/libinput/doc/latest/pointer-acceleration.html). For anyone following this conversation: - `0` is the default - when greater than `0`, acceleration starts sooner

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663671 , @ndavis wrote: > In D29365#663395 , @ngraham wrote: > > > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of leg

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ndavis added a comment. In D29365#663395 , @ngraham wrote: > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The v

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663597 , @ngraham wrote: > Hmm, 0% as a lower value would imply no movement speed, which is obviously not possible here. As far as I know, libinput manages acceleration rather speed. Let's change the l

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Hmm, 0% as a lower value would imply no movement speed, which is obviously not possible here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. Another solution. Spinbox 0% to 100%. -1 is 0% and 1 is 100%. Libinput default 0 will set 50%. // Acceleration RowLayout { Controls.SpinBox { Kirigami.FormData.label: i18nd("kcm_touchpad", "Pointer speed:") id: accelSpeed

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663395 , @ngraham wrote: > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The value displayed to the user must make some sense or explained with context. In this

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 81847. kurmikon added a comment. The spinbox would be better a better solution. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29365?vs=81755&id=81847 REVISION DETAIL https://phabricator.kde.org/D29365 AFFEC

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added reviewers: VDG, Plasma. ngraham added a comment. I agree with the premise that 0.2 steps are much too coarse, and have periodically groused about this myself. However I wonder if 0.05 is too fine? A slider with 41 ticks is screaming out "you used the wrong control for this!" Pe

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Plasma System settings can set only 11 values for touchpad acceleration. The option accept a float number between -1 and 1 but, b