This revision was automatically updated to reflect the committed changes.
Closed by commit R169:db704d344b2c: Improve PageRouter API (authored by cblack).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29288?vs=81555&id=82567
REVISION DETAIL
https://phabric
cblack added inline comments.
INLINE COMMENTS
> cblack wrote in pagerouter.h:443
> It could possibly be a list, but not of pure strings. You want to be able to
> watch a list of routes?
Watching a list of routes is probably going to result in both clunky code and
clunky API design in return fo
cblack added inline comments.
INLINE COMMENTS
> mart wrote in pagerouter.h:443
> could this be just a QStringList?
It could possibly be a list, but not of pure strings. You want to be able to
watch a list of routes?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D292
mart added inline comments.
INLINE COMMENTS
> pagerouter.h:443
> + */
> +Q_PROPERTY(QJSValue watchedRoute READ watchedRoute WRITE setWatchedRoute
> NOTIFY watchedRouteChanged)
> +
could this be just a QStringList?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.or
cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack updated this revision to Diff 81555.
cblack added a comment.
cblack requested review of this revision.
Add missing EOF linebreak
REVISION SUMMARY
