broulik added a comment.
I did, oops, thanks :)
https://cgit.kde.org/plasma-workspace.git/commit/?id=eebbf6d47a3e4e31697162eb082c3489aa1f506e
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29226
To: broulik, #plasma, dfaure
Cc: jbbgameich, dfaure, plasma
jbbgameich added a comment.
Did you possibly forget to commit the changes to the header file?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29226
To: broulik, #plasma, dfaure
Cc: jbbgameich, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
cblack
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:963f41e5593c: [ksmserver] Use CommandLauncherJob for
restoring applications (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29226?vs=
broulik updated this revision to Diff 81419.
broulik added a comment.
- Simplify
- Remove pointless return
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29226?vs=81336&id=81419
REVISION DETAIL
https://phabricator.kde.org/D29226
AFFECTED FILE
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> server.cpp:134
> +for ( int i=1; i < n; i++)
> + argList.append( command[i]);
> +auto *job = new KIO::CommandLauncherJob(app, argList);
(pre-exi
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Rather than calling into `KLauncher` directly.
TEST PLAN
Compiles, session restore apps are sti
