D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

2020-04-23 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ngraham wrote in ClipboardPage.qml:81 > Can this be `enabled:` rather than `visible:`? That's what I did in D29132 > and I think it's nicer and more > consistent with the mockups. never mind, wrong patch REP

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

2020-04-23 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ClipboardPage.qml:81 > Layout.fillWidth: true > -visible: !emptyHint.visible > +visible: clipboardMenu.model.count > 0 > Can this be `enabled:` rather than `visible:`? That's what I did in D29132

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

2020-04-23 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f7687b01cade: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29109?vs=80937&id=81034#toc REPOSITO

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

2020-04-22 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik, niccolove. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Clipboard and Notifications applets live in plasma-workspace; port the