D29064: Support module commandline paramenter

This revision was automatically updated to reflect the committed changes. Closed by commit R124:c3debf5fe0f2: Support module commandline paramenter (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=81319&id=82497 REVISION DET

D29064: Support module commandline paramenter

mart updated this revision to Diff 81319. mart added a comment. - load a new module when a new instance is invoked REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80913&id=81319 BRANCH phab/startupModule REVISION DETAIL https://phabric

D29064: Support module commandline paramenter

broulik added a comment. Note you can pass multiple arguments to `kcmshell5` to open a dedicated save window with random KCMs inside, e.g. done by battery monitor: kcmshell5 powerdevilprofilesconfig powerdevilactivitiesconfig powerdevilglobalconfig Not sure how this could be trans

D29064: Support module commandline paramenter

ngraham added a comment. In D29064#655349 , @mart wrote: > the *really* annoying thing is that every single kcm has a line like > > Exec=kcmshell5 kcm_lookandfeel > > > in its desktop file. Which would call something along the lines

D29064: Support module commandline paramenter

mart added a comment. In D29064#654956 , @ngraham wrote: > Foor fod thought: we might want to also think about some of the consequences of removing kcmshell; we could need to add programmatic cross-KCM navigation into system settings itself. For

D29064: Support module commandline paramenter

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, and I fully support the overall goal of getting rid of kcmshell. Doing so will fix a ton of bugs (all the systemsettings | kcmshell bugs as well as all the bug reports about

D29064: Support module commandline paramenter

mart updated this revision to Diff 80913. mart added a comment. - use namespace REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80904&id=80913 BRANCH phab/startupModule REVISION DETAIL https://phabricator.kde.org/D29064 AFFECTED FILES

D29064: Support module commandline paramenter

ngraham added a comment. This doesn't build for me: /home/nate/kde/src/systemsettings/app/main.cpp: In function ‘int main(int, char**)’: /home/nate/kde/src/systemsettings/app/main.cpp:115:91: error: ‘endl’ was not declared in this scope; did you mean ‘std::endl’? 115 |

D29064: Support module commandline paramenter

bport added inline comments. INLINE COMMENTS > IconMode.cpp:204 > + > +if (!startupModule().isEmpty()) { > +MenuItem *item = rootItem()->descendantForModule(startupModule()); Indentation is not correct REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.

D29064: Support module commandline paramenter

mart updated this revision to Diff 80904. mart marked 2 inline comments as done. mart added a comment. - remove leftovers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80903&id=80904 BRANCH phab/startupModule REVISION DETAIL https://

D29064: support module commandline paramenter

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY in prevision of more or less replacing kcmshell with systemsettings itself, suppo loading a module as a p